-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(messaging): Swift Package Manager support (#13205) #16786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Haven't tested macos though, because one needs a provisioning certificate to run (in this case). Not sure why this is mandatory (but was too lazy honestly to create one, as it should be tested in CI anyways (?)) |
|
@Gustl22 - if you open the example app for macOS in Xcode, remove the entitlements for release mode, you don't need a provisioning profile and the app will build. |
russellwheatley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! A couple of changes and we'll see what the CI says as there might have to be some import updates in ios src/ code
packages/firebase_messaging/firebase_messaging/ios/firebase_messaging/Package.swift
Outdated
Show resolved
Hide resolved
packages/firebase_messaging/firebase_messaging/macos/firebase_messaging/Package.swift
Outdated
Show resolved
Hide resolved
…ssaging/Package.swift Co-authored-by: Russell Wheatley <[email protected]>
…messaging/Package.swift Co-authored-by: Russell Wheatley <[email protected]>
Still not able to build although removing the Signing entitlements in the But I guess it's not that important, if the tests are passing. |
|
@Gustl22 - I had a quick look at this. It seems flutter_local_notifications package hasn't moved to Swift integration and will therefore run You might want to wrap this in an if condition |
# Conflicts: # .github/workflows/scripts/swift-integration.dart
|
Sure, @russellwheatley like that: 8c2f133 ? |
|
@Gustl22 - I've made some updates. Should hopefully get this in soon. |
|
Thank you for taking care of that and investing the time! |
Description
SPM Support for firebase_messaging
Related Issues
#13205
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?